Update to the latest version of Action trait #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <[email protected]>
This was referenced Aug 10, 2025
Signed-off-by: Michael X. Grey <[email protected]>
|
@esteve thanks for approving and merging ros2-rust/rosidl_runtime_rs#15 but this PR is needed to make sure the message bindings are generated correctly for the changes in ros2-rust/rosidl_runtime_rs#15. Until this is merged, users will experience build failures if they're using the latest version of main for both repos. |
|
@xiyuoh pointed out to me that rclrs's main branch is broken after the change in the Action trait definition because the vendored message binding packages are now out of date. I've opened ros2-rust/ros2_rust#539 to resolve that with the minimal amount of changes. |
esteve
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the message binding generation to match ros2-rust/rosidl_runtime_rs#15